fix(event): Fix Duplicate event notification delivery#34
Merged
Conversation
Previously, if multiple subscription rules matched an event and pointed to the same notification target (e.g., the same webhook endpoint or chat ID), multiple identical notifications would be sent. This change modifies the `create_notice_details` service to track sent notifications using a set of unique tuples `(event_id, channel, target)`. This ensures that a notification is delivered only once per unique target, even if triggered by multiple subscriptions. Change-Id: Ibcba09bc62d43d64ddca4862abf44232b74d43bc
weilaaa
pushed a commit
that referenced
this pull request
Nov 26, 2025
Previously, if multiple subscription rules matched an event and pointed to the same notification target (e.g., the same webhook endpoint or chat ID), multiple identical notifications would be sent. This change modifies the `create_notice_details` service to track sent notifications using a set of unique tuples `(event_id, channel, target)`. This ensures that a notification is delivered only once per unique target, even if triggered by multiple subscriptions. Change-Id: Ibcba09bc62d43d64ddca4862abf44232b74d43bc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if multiple subscription rules matched an event and pointed to the same notification target (e.g., the same webhook endpoint or chat ID), multiple identical notifications would be sent.
This change modifies the
create_notice_detailsservice to track sent notifications using a set of unique tuples(event_id, channel, target). This ensures that a notification is delivered only once per unique target, even if triggered by multiple subscriptions.Change-Id: Ibcba09bc62d43d64ddca4862abf44232b74d43bc